Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keycodes): incorrect key code for nine #9568

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

devversion
Copy link
Member

  • Fixes that the @angular/cdk/keycodes package uses a wrong key code for nine.

Fixes #9567

* Fixes that the `@angular/cdk/keycodes` package uses a wrong key code for nine.

Fixes angular#9567
@devversion devversion added pr: needs review target: patch This PR is targeted for the next patch release labels Jan 24, 2018
@devversion devversion requested a review from jelbourn as a code owner January 24, 2018 14:00
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what a weirdly specific bug

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 24, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 637e1b6 into angular:master Jan 25, 2018
@devversion devversion deleted the fix/keycodes-incorrect-nine branch January 25, 2018 15:45
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 29, 2018
`@angular/cdk/keycodes` package used the wrong key code for nine.

Fixes angular#9567
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Code of NINE is wrong
4 participants